Skip to content

handle older PyTorch versions #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Aug 13, 2024
Merged

handle older PyTorch versions #53

merged 32 commits into from
Aug 13, 2024

Conversation

pmcurtin
Copy link
Collaborator

@pmcurtin pmcurtin commented Jul 25, 2024

[draft] this will have to wait until the new logging is merged with main, since some of the CI tests fail?


📚 Documentation preview 📚: https://torchrunx--53.org.readthedocs.build/en/53/

@pmcurtin pmcurtin linked an issue Jul 25, 2024 that may be closed by this pull request
@pmcurtin
Copy link
Collaborator Author

I worked out that in version 2.3 they changed the arguments to start_processes to accept a different kind of logging configuration. We don't really use their logging anymore (at least, not in the logging branch), but we still need to provide the right kind of argument such that it doesn't error out. There might be other compatibility issues, so I need to test some different versions. Hence the draft.

@pmcurtin
Copy link
Collaborator Author

Ok, so with this change I've additionally tested PyTorch versions 2.0.0, 2.1.0, 2.2.0, 2.4.0. I think our dev environment is 2.3.0. So that covers everything >=2.0.0, I think? I don't think minor versions like 2.2.1 would fail if 2.3.0 works?

@apoorvkh
Copy link
Owner

That's great -- the only thing I would add is that we should use a tool like tox in our CI to automatically run the test on all combinations of Python >= 3.8.1 and PyTorch >= 2.0.

@pmcurtin
Copy link
Collaborator Author

Yeah I'll look into doing it automatically with tox.

@pmcurtin
Copy link
Collaborator Author

@apoorvkh
Copy link
Owner

Maybe use Github actions to do the matrix

And Pixi "features" to specify different PyTorch and Python versions

https://pixi.sh/latest/features/multi_environment/#feature-environment-set-definitions

@apoorvkh

This comment was marked as resolved.

@apoorvkh apoorvkh merged commit fd40065 into main Aug 13, 2024
30 checks passed
@apoorvkh apoorvkh deleted the pytorch-compatibility branch August 13, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests and handling for all Pytorch versions >=2.0.0
2 participants